Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run makemigrations after updates to reservation model #720

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

elisakiv
Copy link
Contributor

@elisakiv elisakiv commented Apr 4, 2024

Proposed changes

Run makemigrations after previous updated to reservation model

Checklist

(If any of the points are not relevant, mark them as checked)

  • Remembered to run the makemigrations, makemessages and compilemessages management commands and committed any changes that should be included in this PR
  • Created tests that fail without the changes, if relevant/possible
  • Manually tested that the website UI works as intended with different device layouts
    • (Most common is to test with typical screen sizes for mobile (320-425 px), tablet (768 px) and desktop (1024+ px), which can easily be done with your browser's dev tools)
  • Manually tested that everything works as intended when logged in as different users locally
    • (This can be e.g. anonymous users (i.e. not being logged in), "normal" non-member users, members of different committees, and superusers)
  • Made sure that your code conforms to the code style guides
    • (It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you use it as a reference guide / checklist while taking a second look at your code before opening a pull request)
  • Attempted to minimize the number of common code smells
    • (See the comment for the previous checkbox)
  • Added sufficient documentation - e.g. as comments, docstrings or in the README, if suitable
  • Added your changes to the "Unreleased" section of the changelog - mainly the changes that are of particular interest to users and/or developers, if any
  • Added a "Deployment notes" section above, if anything out of the ordinary should be done when deploying these changes to the server
  • Structured your commits reasonably

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.17%. Comparing base (e30f5f6) to head (89b47f6).

❗ Current head 89b47f6 differs from pull request most recent head 1b23eee. Consider uploading reports for the commit 1b23eee to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #720   +/-   ##
=======================================
  Coverage   88.17%   88.17%           
=======================================
  Files         152      152           
  Lines        6198     6198           
=======================================
  Hits         5465     5465           
  Misses        733      733           

@elisakiv elisakiv merged commit d6a5c8a into dev Apr 4, 2024
10 checks passed
@Gunvor4 Gunvor4 mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants