Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agnostic loading of BROWSER and CATALOG urls #117

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

wildintellect
Copy link
Collaborator

@wildintellect wildintellect commented Sep 25, 2023

#116
Always just sub BROWSER url for STAC url. Can better describe in docs what values are expected. See also #116

Summary:

Old code handled MAAP and VEDA STAC_BROWSER_URL differently, this assumed that the ENV variables were quite different. By standardizing how the ENV is supplied agnostic code can be used, and a fallback in the event of missing variable can also be handled.

Fixes or Addresses Issue #: [ticket number & link]

#116

Checklist before requesting a review:

  • My code follows the guidelines of this project
  • I performed a self-review of my code changes
  • I have added my changes to the change log (HISTORY.rst)
  • I have completed spell-checking, removed unnecessary print statements & commented-out code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

#116 
Always just sub BROWSER url for STAC url. Can better describe in docs what values are expected. See also #116
@wildintellect wildintellect added the bug Something isn't working label Sep 25, 2023
@wildintellect wildintellect self-assigned this Sep 25, 2023
@wildintellect wildintellect marked this pull request as ready for review September 26, 2023 20:40
Copy link
Collaborator

@sandrahoang686 sandrahoang686 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wildintellect wildintellect merged commit 4260b07 into main Sep 26, 2023
@wildintellect wildintellect mentioned this pull request Sep 26, 2023
@wildintellect wildintellect deleted the fix/stac_browser_url-missing branch September 27, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants