Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/state breakdown #334

Merged
merged 8 commits into from
Mar 15, 2024
Merged

Conversation

lyricnz
Copy link
Contributor

@lyricnz lyricnz commented Mar 15, 2024

Per #333

eg: victoria (CSV loaded in spreadsheet and graphed)

image

It would be nice to support this render in stats.html with a state/national dropdown

@lyricnz
Copy link
Contributor Author

lyricnz commented Mar 15, 2024

@LukePrior this PR creates results/breakdown-state.json and results/breakdown.$STATE.csv - would you prefer results/$STATE/breakdown.csv for the latter?

@LukePrior
Copy link
Owner

Thanks for this,

I think in this case results/breakdown.$STATE.csv is fine for now, in future might move things to a breakdown folder.

@lyricnz lyricnz marked this pull request as ready for review March 15, 2024 08:30
@lyricnz
Copy link
Contributor Author

lyricnz commented Mar 15, 2024

I'll connect it to the update job, sec

@lyricnz
Copy link
Contributor Author

lyricnz commented Mar 15, 2024

I'll raise a new PR "someday" to make the stats.html use this data too...

@LukePrior LukePrior merged commit b1a8ccf into LukePrior:main Mar 15, 2024
@lyricnz lyricnz deleted the feature/state-breakdown branch March 15, 2024 08:43
@LukePrior
Copy link
Owner

I did a quick and dirty implementation just so it can be viewed:

0f95df3

https://lukeprior.github.io/nbn-upgrade-map/stats?region=NSW

@lyricnz
Copy link
Contributor Author

lyricnz commented Mar 15, 2024

@LukePrior I just had FTTP installed at my place, and was chatting to the contractors. They were super interested in the data from this project, hence the feature-request here. Their particular interest was how much FTTN/FTTC/HFC -> FTTP work was left in Victoria, hence how much more work was available for them. I write the PR above while they were digging :)

@lyricnz
Copy link
Contributor Author

lyricnz commented Mar 15, 2024

@LukePrior I suck at javascript, but attempted to add a dropdown for changing regions

Screen.Recording.2024-03-16.at.10.13.42.AM.mov

#336
PS: I fixed the wrong option being selected :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants