Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing Page UI changes #35

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

roykhushi
Copy link

Removed the strikethrough in the explore button and changed the contrast and visibility of the main and sub text

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nomen ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 4:15pm

Copy link
Owner

@Luciferlocas Luciferlocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Efforts appreciated, but the color of then NomeN is not matching the colors we have used in the whole site. Plus the explore button is way too large. Reduce the size a little bit and check the colors being used in the application.

@roykhushi
Copy link
Author

Efforts appreciated, but the color of then NomeN is not matching the colors we have used in the whole site. Plus the explore button is way too large. Reduce the size a little bit and check the colors being used in the application.

image

I have now applied the same color-gradient that is being used in the "text-reveal-card.tsx" and decreased the button size. Do let me know if you want further changes.

@roykhushi
Copy link
Author

@Luciferlocas pls review the changes done this time

Copy link
Owner

@Luciferlocas Luciferlocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fetch the latest changes and then make the necessary changes. The size of the explore button on did is really looking good, the color or NomeN however is fading due to the white color of welcome to. Try to change in and grab the attention of the user to NomeN.

The special-button can be customized externally without having the need to change the actual code written inside.

@roykhushi
Copy link
Author

Okay, sure, but could you please tell me which color shades you'll prefer or have in mind? Do you prefer shades of black/gray/ white as in the color scheme used for the whole website , or will any other popping color work? It would be helpful.

@Luciferlocas
Copy link
Owner

I really don't have anything in mind, the thing is I want to highlight "NomeN" by using simple gray/white color. The shade your gave to NomeN was really looking good, but the issue is in comparison to the white color of welcome to, if was fading away. And the issue while changing the style of the special-button is that it is a component which is being used for many buttons, changing directly the main component will cause the other usage change and they might not look good.

@roykhushi
Copy link
Author

Okay, I understood. I will make the changes and update you soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants