refactor!: replace unnecessary classes with pure functions #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES:
- Removes `YTNodeGenerator` from `import('youtubei.js').Generator` and exposes its functions directly in `import('youtubei.js').Generator`
- Remove Parser class in favour of pure functions - Merge duplicate classes `AppendContinuationItemsAction` into a single class - Move continuation parsers into a seperate file - Add better custom logging support to parser methods as per issue #460
- Replace linkedom DASH manifest generation with a dependency free JSX implementation - Remove FormatUtils class in favour of pure functions - Remove DOMParser requirement - Remove duplicate types
|
I forgot to pull the latest changes before I refactored FormatUtils 💀 |
LuanRT
reviewed
Aug 10, 2023
Co-authored-by: LuanRT <[email protected]>
This allows users to access the same data available in the dash manifest while also simplifying the manifest generation
Remove redundant getAudioTrackGroups General readability improvements in StreamingInfo.ts Share response object between `getBitrate` and `getMimeType` as to not make duplicate requests
absidue
reviewed
Aug 12, 2023
LuanRT
approved these changes
Aug 18, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed on Discord by @absidue, this PR aims to replace
Proto,FormatUtils,ParserandYTNodeGeneratorwith pure functions, allowing better bundler support.Breaking Changes:
YTNodeGeneratorfromimport('youtubei.js').Generatorand exposes its functions directly inimport('youtubei.js').GeneratorParserclass in favour of namespaced pure functionsProtoclass in favour of namespaced pure functionsAppendContinuationItemsActioninto a single class (removes theitemsproperty in favour ofcontents)Parser#setParserErrorHandlerfunction signature has changed slightly.Other changes:
Additions:
MediaInfo#getStreamingInfo- gets the same data available in the Dash manifest as a js object