Linkage origins mod #1179
Closed
Linkage origins mod #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/resources/assets/changed/lang/zh_cn.json
# Conflicts: # src/main/resources/assets/changed/lang/zh_cn.json
# Conflicts: # src/main/resources/assets/changed/lang/zh_cn.json
LtxProgrammer
requested changes
Nov 20, 2024
There was a problem hiding this comment.
I'm not a fan of the classes that are initialized for a single condition check (CheckCondition, LatexPhantom). I've attempted to communicate this in the previous PRs but that hasn't been successful. There is also no consistency between function names or line spacings.
This code is also not that efficient, with the creation of the check classes and the static map tracking burn cooldowns.
src/main/java/net/ltxprogrammer/changed/latexvariant/origins/LatexPhantom.java
Outdated
Show resolved
Hide resolved
src/main/java/net/ltxprogrammer/changed/latexvariant/origins/LatexPhantom.java
Outdated
Show resolved
Hide resolved
| if (serverPlayer.level.isDay()) { | ||
| long currentTime = serverPlayer.level.getGameTime(); | ||
| if (!playerCooldown.containsKey(serverPlayer) || currentTime - playerCooldown.get(serverPlayer) >= 100) { | ||
| serverPlayer.setSecondsOnFire(5); |
There was a problem hiding this comment.
This does not need to track cooldowns. Repeatedly setting ticks on fire has less overhead cost than checking a map to see if the player should be set on fire.
src/main/java/net/ltxprogrammer/changed/latexvariant/origins/LatexPhantom.java
Outdated
Show resolved
Hide resolved
src/main/java/net/ltxprogrammer/changed/latexvariant/CheckCondition.java
Outdated
Show resolved
Hide resolved
src/main/java/net/ltxprogrammer/changed/latexvariant/CheckCondition.java
Outdated
Show resolved
Hide resolved
src/main/java/net/ltxprogrammer/changed/latexvariant/CheckCondition.java
Outdated
Show resolved
Hide resolved
src/main/java/net/ltxprogrammer/changed/latexvariant/CheckCondition.java
Outdated
Show resolved
Hide resolved
|
Closing as I have implemented config and fixed the issue related to phantoms suffocating when transfurred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
-Rewrote Phantom's behavior and added LatexPhantom (a variant of Phantom)
-Adding configuration files about origins