Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only pick up items if they are from the same build mode #22

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

sekwah41
Copy link
Member

This should fix #7 as well as avoid having items not from the build mode menu being able to get into there. Hoever if we dont have the block drops off the blocks dropped would still spawn without the tag so not sure if this 100% fixes the issue.

@sekwah41
Copy link
Member Author

Just let me know if there is anything else needed to help close the issue.

Copy link
Member

@Gegy Gegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This works great for having tile drops off.
In general, I think we should mark any blocks dropped from a build mode player mining a block (or, more generally any loot table evaluating due to that player).

@sekwah41
Copy link
Member Author

sekwah41 commented Nov 15, 2024

I held off on the block drops from build mode entirely being set just in case there were edge cases I wasn't thinking of, that plus no tile drops would mean its not an issue for now at least. We can take a look at altering that logic in another pr though ^.^ Im going to merge this for now as its a useful upgrade in its current state.

@sekwah41 sekwah41 merged commit bf5e396 into 1.21 Nov 15, 2024
2 checks passed
@sekwah41 sekwah41 deleted the drop-filter branch November 15, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can only trash items that were directly taken out of the build menu
2 participants