Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cluster and Tags to DefaultSeekHeadTargets #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Zeugma440
Copy link
Contributor

You're welcome 😉

@LostBeard
Copy link
Owner

Cluster and Tags can occur multiple times in a Segment. Which one(s) should it create Seek entries for? The others are there because they can only occur once, so auto-populating for those is easy.

@LostBeard
Copy link
Owner

Without adding those entries it already will update all Seek entries that are found, including Cluster and Tags

@Zeugma440
Copy link
Contributor Author

Zeugma440 commented Aug 23, 2024

Without adding those entries it already will update all Seek entries that are found, including Cluster and Tags

I added those because I had an issue where adding a new Tags entry over a file that hadn't any wouldn't be taken into account into SeekHead. The content of that PR fixed it for me.

In all honesty, my library won't add extra Cluster elements, so you may skip that one if that's easier for you.

Cluster and Tags can occur multiple times in a Segment. Which one(s) should it create Seek entries for? The others are there because they can only occur once, so auto-populating for those is easy.

I didn't realize Tags could occur multiple times 👍 Specs aren't super clear about how SeekHead should react to indexing multiple instances of the same element, and I don't plan on writing multiple Tags elements in my library anyway, so maybe we should support indexing the first one only, and wait until the use case for multiple Tags arises?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants