feat: support both sync and async curl transactions #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzoLeonardo
force-pushed
the
40-a-need-to-also-support-synchronous-curl-making-this-library-dynamic-that-could-perform-both-sync-and-async-transactions
branch
3 times, most recently
from
857db60 to
e7ee6aa
Compare
There is a slight change in the builder pattern so that we could be able to use this crate dynamically both sync and async transactions for Curl rust.
LorenzoLeonardo
force-pushed
the
40-a-need-to-also-support-synchronous-curl-making-this-library-dynamic-that-could-perform-both-sync-and-async-transactions
branch
2 times, most recently
from
e22c7f7 to
3c2dbaf
Compare
The purpose of the major version up is to cater both synchronous and asynchronous transactions for curl-rust. There are breaking changes in terms of the builder pattern. We use blocking() to signify the end of the Curl builder to do a blocking perform after and nonblocking() to signify the end of the Curl builder to do a nonblocking perform after. For nonblocking transaction, the actor handler is now passed into nonblocking function instead in the new constructor of the HttpClient.
LorenzoLeonardo
force-pushed
the
40-a-need-to-also-support-synchronous-curl-making-this-library-dynamic-that-could-perform-both-sync-and-async-transactions
branch
from
3c2dbaf to
0f380d0
Compare
LorenzoLeonardo
deleted the
40-a-need-to-also-support-synchronous-curl-making-this-library-dynamic-that-could-perform-both-sync-and-async-transactions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a slight change in the builder pattern so that we could be able to use this crate dynamically both sync and async transactions for Curl rust.