Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Messaging rewrite #296

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Conversation

LossyDragon
Copy link
Collaborator

Description

  • Fix comparison in NetHelpers.
  • Add gamenotifications proto.
  • Remove ICallbackMsg
  • Cleanup callback manager internals.
  • Add isDisconnected() (checks connection object too)
  • Rework Unified Messaging to use less reflection.

Misc

  • Stop auto generated classes from being linted.

Checklist

  • Code compiles correctly
  • All tests passing
  • Samples run successfully
  • Extended the README / documentation, if necessary

Stop auto generated classes from being linted.
Fix comparison in NetHelpers.
Subscription is just a pointless wrapper around CallbackBase which is Closeable by itself.
@LossyDragon LossyDragon merged commit 17542d1 into Longi94:master Nov 7, 2024
1 check passed
@LossyDragon LossyDragon deleted the unified-rewrite branch November 7, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant