Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop ktlint (kotlinter) from changing line separators #286

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

LossyDragon
Copy link
Collaborator

Description

Checking out files on windows creates the files as crlf, and editorconfig didnt so anything when changing the end_of_line field. So no matter what, building always changed kt files back to lf, creating (many) useless files staged for commit.

pinterest/ktlint issue 2747

Checklist

  • Code compiles correctly
  • All tests passing
  • Samples run successfully
  • Extended the README / documentation, if necessary

…erent operating systems.

Checking out through windows makes files clrf and the editorconfig didn't really respect it. So when building, ktlint would always create useless modified files which only changed the line separator.
@LossyDragon LossyDragon marked this pull request as ready for review October 10, 2024 04:21
@LossyDragon LossyDragon merged commit 976049b into Longi94:master Oct 10, 2024
1 check passed
@LossyDragon LossyDragon deleted the line-separator branch October 10, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant