Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse StringBuilder in KVTextReader #280

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Reuse StringBuilder in KVTextReader #280

merged 2 commits into from
Sep 30, 2024

Conversation

LossyDragon
Copy link
Collaborator

Description

  • Simplifies re-creating a StringBuilder or ByteArrayOutputStream every time readToken is called.
  • Add missing KV tests

Checks off PR 1389 in #181

Checklist

  • Code compiles correctly
  • All tests passing
  • Samples run successfully
  • Extended the README / documentation, if necessary

@LossyDragon LossyDragon merged commit ad5ea0b into Longi94:master Sep 30, 2024
1 check passed
@LossyDragon LossyDragon deleted the kvtr-stringbuilder branch September 30, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LossyDragon