Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive header and theory page #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saramorillon
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jan 5, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/arrestierchristophe/teamhealthcheck/3g1zp78za
✅ Preview: https://teamhealthcheck-git-fork-picusviridis-howto-responsive.arrestierchristophe.now.sh


useEffect(() => {
setHidden(true);
}, [pathname]);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand what you are trying to achieve here... If you change location you display header again ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change location you hide the menu


return (
<header className={classNames({ medium, light: light && !sticky, sticky })}>
<span className="icon material-icons" onClick={toggleMenu}>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mecanism is neat but in responsive mode i'm not satisfied with a full width header. It would be nice to have the burger menu display just in a "thumbnail" or a bookmark, like (ascii style) :

----
Menu )
----

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the bottom border ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like, float left ?

}

.menu {
background-color: $base_grey;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a less "dirt-like" color ? Maybe black on white or white on black ...
The best option i can think of right now is black on white with a "blur" filter on the rest of the page to hide it (like a modal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants