-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive header and theory page #3
base: master
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/arrestierchristophe/teamhealthcheck/3g1zp78za |
|
||
useEffect(() => { | ||
setHidden(true); | ||
}, [pathname]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure to understand what you are trying to achieve here... If you change location you display header again ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change location you hide the menu
|
||
return ( | ||
<header className={classNames({ medium, light: light && !sticky, sticky })}> | ||
<span className="icon material-icons" onClick={toggleMenu}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mecanism is neat but in responsive mode i'm not satisfied with a full width header. It would be nice to have the burger menu
display just in a "thumbnail" or a bookmark, like (ascii style) :
----
Menu )
----
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the bottom border ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like, float left ?
} | ||
|
||
.menu { | ||
background-color: $base_grey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a less "dirt-like" color ? Maybe black on white or white on black ...
The best option i can think of right now is black on white with a "blur" filter on the rest of the page to hide it (like a modal)
No description provided.