Skip to content

Commit

Permalink
Fix mozjs build on Windows (servo#34680)
Browse files Browse the repository at this point in the history
Signed-off-by: Delan Azabani <[email protected]>
  • Loading branch information
delan authored Dec 18, 2024
1 parent 3a4e5d4 commit 11424f9
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions python/servo/command_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -832,6 +832,10 @@ def run_cargo_build_like_command(
if with_debug_assertions or self.config["build"]["debug-assertions"]:
env['RUSTFLAGS'] = env.get('RUSTFLAGS', "") + " -C debug_assertions"

# mozjs gets its Python from `env['PYTHON3']`, which defaults to `python3`,
# but uv venv on Windows only provides a `python`, not `python3`.
env['PYTHON3'] = "python"

return call(["cargo", command] + args + cargo_args, env=env, verbose=verbose)

def android_adb_path(self, env):
Expand Down

0 comments on commit 11424f9

Please sign in to comment.