Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use workflow_run to allow secrets on dependabot and fork PRs #18

Conversation

ReenigneArcher
Copy link
Member

Description

This PR should fix the ability of dependabot and PRs from forks to properly run the CI in this repo.

Todo:

  • Determine if this will automatically add statuses for the sha, so they will be visible as status checks in PRs.
    • If yes, remove commented out blocks
    • If no, enable commented out blocks

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the ci-use-workflow_run-to-allow-secrets-on-dependabot-and-fork-PRs branch from 21c9894 to 6684f16 Compare October 26, 2023 22:01
@ReenigneArcher ReenigneArcher force-pushed the ci-use-workflow_run-to-allow-secrets-on-dependabot-and-fork-PRs branch from 6684f16 to b6e5a11 Compare October 26, 2023 22:14
@ReenigneArcher
Copy link
Member Author

Replaced by #19

@ReenigneArcher ReenigneArcher deleted the ci-use-workflow_run-to-allow-secrets-on-dependabot-and-fork-PRs branch October 26, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci cannot run on dependabot or forks
1 participant