Add a fallback for the time tracking in the web #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every browser's `performance.now()` implementation is not spec compliant, unless the browser is running on Windows. On every other operating system, `performance.now()` does not properly keep ticking while the operating system is suspended / sleeping. There isn't much that we can do. What we can do is we calculate the initial difference between `performance.now()` and `Date.now()` and store it in a thread local. Later, when the phone gets locked, `performance.now()` starts to break. However, we can detect when the phone gets unlocked again by listening to the `visibilitychange` event. This is where we can update the difference again. This of course isn't ideal, as `Date.now()` gets adjusted by NTP synchronizations, but it's the best we can do. More information: https://developer.mozilla.org/en-US/docs/Web/API/Performance/now#ticking_during_sleep
CryZe
added
bug
AlexKnauth
pushed a commit
to AlexKnauth/livesplit-core
that referenced
this pull request
Jun 13, 2024
Every browser's `performance.now()` implementation is not spec compliant, unless the browser is running on Windows. On every other operating system, `performance.now()` does not properly keep ticking while the operating system is suspended / sleeping. There isn't much that we can do. What we can do is we calculate the initial difference between `performance.now()` and `Date.now()` and store it in a thread local. Later, when the phone gets locked, `performance.now()` starts to break. However, we can detect when the phone gets unlocked again by listening to the `visibilitychange` event. This is where we can update the difference again. This of course isn't ideal, as `Date.now()` gets adjusted by NTP synchronizations, but it's the best we can do. More information: https://developer.mozilla.org/en-US/docs/Web/API/Performance/now#ticking_during_sleep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every browser's
performance.now()implementation is not spec compliant, unless the browser is running on Windows. On every other operating system,performance.now()does not properly keep ticking while the operating system is suspended / sleeping. There isn't much that we can do. What we can do is we calculate the initial difference betweenperformance.now()andDate.now()and store it in a thread local. Later, when the phone gets locked,performance.now()starts to break. However, we can detect when the phone gets unlocked again by listening to thevisibilitychangeevent. This is where we can update the difference again. This of course isn't ideal, asDate.now()gets adjusted by NTP synchronizations, but it's the best we can do.More information:
https://developer.mozilla.org/en-US/docs/Web/API/Performance/now#ticking_during_sleep