Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process_get_module_path #735

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

AlexKnauth
Copy link
Contributor

This adds process_get_module_path to the Auto Splitting Runtime, which gets the path on the file system to the module.

This is useful in situations where the Section Header Table is there in the file, but is not loaded into memory, even when the rest of the module is.

@AlexKnauth AlexKnauth marked this pull request as draft November 1, 2023 14:40
@CryZe
Copy link
Collaborator

CryZe commented Nov 1, 2023

This looks good. I'd like to improve the docs a bit though. So I'll rebase this for you.

@AlexKnauth
Copy link
Contributor Author

I also saw the changes to process_get_path in #736, and I would like to include analogs of those changes in here.

@CryZe
Copy link
Collaborator

CryZe commented Nov 1, 2023

Yeah I'll port those as well.

@CryZe CryZe force-pushed the process_get_module_path branch from ada44c6 to 10173b5 Compare November 1, 2023 15:06
@CryZe CryZe marked this pull request as ready for review November 1, 2023 15:06
@CryZe CryZe added enhancement An improvement for livesplit-core. auto splitting This is about the auto splitting implementation. labels Nov 1, 2023
@CryZe CryZe added this to the v0.14 milestone Nov 1, 2023
@CryZe CryZe merged commit ee71245 into LiveSplit:master Nov 1, 2023
76 checks passed
@AlexKnauth AlexKnauth deleted the process_get_module_path branch November 1, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto splitting This is about the auto splitting implementation. enhancement An improvement for livesplit-core.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants