Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React to v18 #897

Merged
merged 5 commits into from
Jun 1, 2024
Merged

Upgrade React to v18 #897

merged 5 commits into from
Jun 1, 2024

Conversation

wooferzfg
Copy link
Member

@wooferzfg wooferzfg commented May 28, 2024

Resolves #894

  • Upgrade react and react-dom to v18
  • Upgrade react-toastify to v10

It seems as though we have a lot of packages that haven't been updated in years with peer dependencies that do not include the latest React version. They still seem to be working, though, so just using npm install -f might be okay?

wooferzfg added 5 commits May 28, 2024 17:32
Upgrading React to v18
Upgrading react-toastify to v10
Also no longer use toast.POSITION since it was removed in v10
Some packages' peer dependencies are broken now since they haven't been updated in years
Some packages' peer dependencies are broken now since they haven't been updated in years
@wooferzfg wooferzfg marked this pull request as ready for review May 29, 2024 01:06
@wooferzfg wooferzfg requested a review from CryZe May 29, 2024 01:06
@CryZe CryZe merged commit d4e4764 into LiveSplit:master Jun 1, 2024
1 check passed
@CryZe CryZe added enhancement A new feature or general improvement to LiveSplit One. dependencies Pull requests that update a dependency file labels Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement A new feature or general improvement to LiveSplit One.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to React 18
2 participants