Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support node 18, 20 & 21 #121

Conversation

termontwouter
Copy link
Contributor

No description provided.

Copy link
Member

@rubensworks rubensworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one question.

package.json Outdated
@@ -103,5 +103,8 @@
"rimraf": "latest",
"ts-jest": "^29.0.0",
"typescript": "^5.0.0"
},
"resolutions": {
"@comunica/bus-http": "^2.10.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one really needed? I suspect resetting the lockfile should be sufficient to bump the comunica stack.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are totally right 🤦

Signed-off-by: Wouter Termont <[email protected]>
@rubensworks rubensworks merged commit b8f121a into LinkedSoftwareDependencies:master Nov 24, 2023
23 checks passed
@rubensworks
Copy link
Member

Thanks!

@termontwouter termontwouter deleted the feat/support-node-18-20-21 branch December 19, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants