Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add huawei cloud msgsms support #1

Merged
merged 7 commits into from
Oct 20, 2023
Merged

feat: add huawei cloud msgsms support #1

merged 7 commits into from
Oct 20, 2023

Conversation

ho-229
Copy link
Member

@ho-229 ho-229 commented Oct 16, 2023

No description provided.

@ho-229 ho-229 self-assigned this Oct 17, 2023
@ho-229 ho-229 requested a review from STRRL October 17, 2023 10:57
Copy link

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM!

internal/api/sms_provider/huawei_cloud.go Show resolved Hide resolved
internal/api/sms_provider/huawei_cloud.go Outdated Show resolved Hide resolved
Copy link

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM!

@ho-229 ho-229 requested a review from STRRL October 18, 2023 11:39
@STRRL
Copy link

STRRL commented Oct 20, 2023

LGTM! Great!! 🚀

@STRRL STRRL merged commit b797a03 into master Oct 20, 2023
1 check passed
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ho-229 ho-229 deleted the huawei_msgsms branch October 20, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants