Fail loud should apply consistently #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakelley
force-pushed
the
fail-loud-should-apply-consistently
branch
from
73db243
to
ad7061c
Compare
|
I fixed the test and config to pass CI on 7.1 - 7.3, it doesn't appear the 8.0 nightly is a compatible target and should likely be dropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we understand it, the intent behind
fail_loudis to allow graceful degradation to client-side-only rendering in production if SSR fails. The current implementation currently only supports this for errors returned by the JS rendering implementation, rather than generated by the PHP renderer itself. This PR changesfail_loud: falseto universally prevent SSR-originating errors from preventing page rendering. If this is not a desired change, an alternative would be to add a separate option to control this behavior.This change required bumping the minimum PHP version to permit
\Throwable, I hope this is acceptable as at this point such versions are long past EOL.