Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balances): latest implementation #420

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Conversation

failfmi
Copy link
Collaborator

@failfmi failfmi commented Jun 10, 2024

Description

  • latest implementation
  • extrinsic calls
  • metadata
  • tests
  • integration tests
  • benchmarks

Fixes #365

Checklist:

  • I have read the contributing guidelines.
  • My PR title matches the Conventional Commits spec.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I can start a Substrate node using the updated runtime.

@failfmi failfmi self-assigned this Jun 10, 2024
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 53.48837% with 720 lines in your changes missing coverage. Please review.

Project coverage is 76.25%. Comparing base (2d3bcf2) to head (42a8f62).

Files Patch % Lines
frame/balances/module.go 28.60% 250 Missing and 17 partials ⚠️
frame/balances/call_force_adjust_total_issuance.go 11.84% 67 Missing ⚠️
frame/balances/call_transfer_allow_death.go 12.69% 55 Missing ⚠️
frame/balances/call_upgrade_accounts.go 15.68% 43 Missing ⚠️
frame/balances/call_transfer_all.go 9.09% 40 Missing ⚠️
frame/balances/types/withdrawal_consequence.go 0.00% 38 Missing ⚠️
frame/balances/call_force_transfer.go 11.42% 31 Missing ⚠️
frame/balances/events.go 14.28% 30 Missing ⚠️
frame/balances/call_transfer_keep_alive.go 12.12% 29 Missing ⚠️
frame/balances/types/deposit_consequence.go 0.00% 28 Missing ⚠️
... and 13 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #420      +/-   ##
===========================================
- Coverage    80.34%   76.25%   -4.09%     
===========================================
  Files          298      307       +9     
  Lines        14673    15356     +683     
===========================================
- Hits         11789    11710      -79     
- Misses        2387     3144     +757     
- Partials       497      502       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@failfmi failfmi requested a review from radkomih June 11, 2024 12:56
@failfmi failfmi linked an issue Jun 11, 2024 that may be closed by this pull request
9 tasks
@failfmi failfmi marked this pull request as ready for review June 14, 2024 11:51
@failfmi failfmi merged commit 095050b into develop Jun 14, 2024
5 of 7 checks passed
@failfmi failfmi deleted the feat/balances/implementation branch June 14, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

update balances module
2 participants