Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable sudo guards and update tests #418

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

radkomih
Copy link
Collaborator

@radkomih radkomih commented Jun 7, 2024

Description

Fixes #408

  • enable origin checks
  • fix handling errors and execute extrinsics logic
  • fix transaction validity error implementation
  • refactor logger

Checklist:

  • I have read the contributing guidelines.
  • My PR title matches the Conventional Commits spec.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I can start a Substrate node using the updated runtime.

@radkomih radkomih self-assigned this Jun 7, 2024
@radkomih radkomih changed the title update: enable sudo guards and update tests refactor: enable sudo guards and update tests Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 85.60000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 80.34%. Comparing base (2f94012) to head (82a404e).

Files Patch % Lines
testhelpers/testhelpers.go 0.00% 7 Missing ⚠️
primitives/log/logger_nonwasm.go 77.77% 6 Missing ⚠️
frame/executive/executive.go 81.81% 1 Missing and 1 partial ⚠️
frame/grandpa/equivocation.go 0.00% 1 Missing ⚠️
frame/session_historical/module.go 0.00% 1 Missing ⚠️
primitives/types/transaction_validity_error.go 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #418      +/-   ##
===========================================
+ Coverage    80.29%   80.34%   +0.04%     
===========================================
  Files          298      298              
  Lines        14641    14673      +32     
===========================================
+ Hits         11756    11789      +33     
+ Misses        2388     2387       -1     
  Partials       497      497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radkomih
Copy link
Collaborator Author

radkomih commented Jun 7, 2024

found bug in the execution

@radkomih radkomih force-pushed the update/sudo-guards branch from c389a83 to 6fb6146 Compare June 11, 2024 10:40
@radkomih radkomih requested a review from failfmi June 11, 2024 12:09
@failfmi failfmi merged commit 4639b9a into develop Jun 11, 2024
7 checks passed
@failfmi failfmi deleted the update/sudo-guards branch June 11, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

sudo: enable the guard checks in extrinsic calls
2 participants