Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grandpa): update #411

Merged
merged 8 commits into from
Jun 6, 2024
Merged

feat(grandpa): update #411

merged 8 commits into from
Jun 6, 2024

Conversation

radkomih
Copy link
Collaborator

@radkomih radkomih commented May 20, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context,
including:

  • What does this PR do?
  • Why are these changes needed?
  • How were these changes implemented and what do they affect?

Use Github semantic linking to address any open issues this PR relates to or closes.

Fixes #399

TODO: Implement the trie proving logic (session_historical module) once the changes containing the trie fixes are merged.

Checklist:

  • I have read the contributing guidelines.
  • My PR title matches the Conventional Commits spec.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I can start a Substrate node using the updated runtime.

@radkomih radkomih self-assigned this May 20, 2024
@radkomih radkomih force-pushed the feat/module/grandpa branch from b5c54b9 to 72a1132 Compare May 20, 2024 05:47
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 73.48378% with 376 lines in your changes missing coverage. Please review.

Project coverage is 80.29%. Comparing base (b735df7) to head (4d0a30f).

Files Patch % Lines
frame/grandpa/equivocation.go 0.00% 69 Missing ⚠️
frame/grandpa/module.go 65.19% 48 Missing and 15 partials ⚠️
frame/session_historical/module.go 0.00% 50 Missing ⚠️
frame/grandpa/call_report_equivocation.go 18.75% 39 Missing ⚠️
frame/grandpa/call_report_equivocation_unsigned.go 18.75% 39 Missing ⚠️
api/grandpa/module.go 34.14% 27 Missing ⚠️
frame/authorship/module.go 81.63% 5 Missing and 4 partials ⚠️
frame/babe/module.go 52.94% 8 Missing ⚠️
primitives/io/offchain.go 0.00% 8 Missing ⚠️
frame/grandpa/events.go 77.77% 3 Missing and 3 partials ⚠️
... and 17 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #411      +/-   ##
===========================================
- Coverage    81.08%   80.29%   -0.80%     
===========================================
  Files          270      298      +28     
  Lines        13499    14641    +1142     
===========================================
+ Hits         10946    11756     +810     
- Misses        2077     2388     +311     
- Partials       476      497      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@failfmi failfmi self-requested a review June 3, 2024 09:38
@radkomih radkomih force-pushed the feat/module/grandpa branch from 72a1132 to fe63f85 Compare June 3, 2024 10:10
@radkomih radkomih force-pushed the feat/module/grandpa branch from 4327422 to 103c1f6 Compare June 4, 2024 06:49
frame/grandpa/call_note_stalled.go Outdated Show resolved Hide resolved
api/grandpa/module.go Outdated Show resolved Hide resolved
runtime/templates/pos/runtime.go Show resolved Hide resolved
api/grandpa/module.go Outdated Show resolved Hide resolved
frame/grandpa/module.go Outdated Show resolved Hide resolved
frame/authorship/module.go Outdated Show resolved Hide resolved
frame/grandpa/call_report_equivocation.go Outdated Show resolved Hide resolved
frame/babe/call_plan_config_change.go Outdated Show resolved Hide resolved
frame/grandpa/call_report_equivocation_unsigned.go Outdated Show resolved Hide resolved
polkadot-sdk Outdated Show resolved Hide resolved
@failfmi failfmi self-requested a review June 6, 2024 06:32
failfmi
failfmi previously approved these changes Jun 6, 2024
@radkomih radkomih merged commit 0404434 into develop Jun 6, 2024
4 of 6 checks passed
@radkomih radkomih deleted the feat/module/grandpa branch June 6, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add grandpa module
2 participants