-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grandpa): update #411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radkomih
force-pushed
the
feat/module/grandpa
branch
from
May 20, 2024 05:47
b5c54b9
to
72a1132
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #411 +/- ##
===========================================
- Coverage 81.08% 80.29% -0.80%
===========================================
Files 270 298 +28
Lines 13499 14641 +1142
===========================================
+ Hits 10946 11756 +810
- Misses 2077 2388 +311
- Partials 476 497 +21 ☔ View full report in Codecov by Sentry. |
radkomih
force-pushed
the
feat/module/grandpa
branch
from
June 3, 2024 10:10
72a1132
to
fe63f85
Compare
radkomih
force-pushed
the
feat/module/grandpa
branch
from
June 4, 2024 06:49
4327422
to
103c1f6
Compare
failfmi
reviewed
Jun 4, 2024
failfmi
previously approved these changes
Jun 6, 2024
failfmi
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context,
including:
Use Github semantic linking to address any open issues this PR relates to or closes.
Fixes #399
TODO: Implement the trie proving logic (session_historical module) once the changes containing the trie fixes are merged.
Checklist: