Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modules): sudo #404

Merged
merged 6 commits into from
Apr 19, 2024
Merged

feat(modules): sudo #404

merged 6 commits into from
Apr 19, 2024

Conversation

failfmi
Copy link
Collaborator

@failfmi failfmi commented Apr 11, 2024

Description

  • Sudo
    • extrinsic calls
    • metadata
    • unit tests
    • genesis config
    • weights

Fixes #383

Checklist:

  • I have read the contributing guidelines.
  • My PR title matches the Conventional Commits spec.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I can start a Substrate node using the updated runtime.

@failfmi failfmi requested a review from radkomih April 11, 2024 08:25
@failfmi failfmi self-assigned this Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 93.73913% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 83.92%. Comparing base (aacc32e) to head (88787e3).

Files Patch % Lines
frame/sudo/events.go 70.00% 6 Missing and 6 partials ⚠️
frame/sudo/call_sudo_as.go 87.71% 4 Missing and 3 partials ⚠️
frame/sudo/call_set_key.go 90.56% 3 Missing and 2 partials ⚠️
frame/sudo/call_sudo_unchecked_weight.go 91.83% 2 Missing and 2 partials ⚠️
frame/sudo/genesis_builder.go 80.95% 2 Missing and 2 partials ⚠️
frame/sudo/call_sudo.go 95.45% 1 Missing and 1 partial ⚠️
frame/sudo/module.go 99.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #404      +/-   ##
===========================================
+ Coverage    83.36%   83.92%   +0.56%     
===========================================
  Files          227      242      +15     
  Lines        11128    11692     +564     
===========================================
+ Hits          9277     9813     +536     
- Misses        1467     1479      +12     
- Partials       384      400      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radkomih
radkomih previously approved these changes Apr 19, 2024
frame/sudo/call_sudo_unchecked_weight.go Outdated Show resolved Hide resolved
@failfmi failfmi merged commit c0a84d3 into develop Apr 19, 2024
6 checks passed
@failfmi failfmi deleted the feat/frame/sudo branch April 19, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add sudo module
2 participants