forked from LimeChain/Fruzhin
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement WsRpcClient and support all required rpc methods. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Grigorov-Georgi
approved these changes
Sep 19, 2024
georg-getz
reviewed
Sep 19, 2024
georg-getz
reviewed
Sep 19, 2024
georg-getz
reviewed
Sep 19, 2024
georg-getz
approved these changes
Sep 19, 2024
Zurcusa
added a commit
that referenced
this pull request
Sep 19, 2024
# Description Remove deprecated http rpc client api export and related code. Remove LoadBalancer. Use only one node for HTTP rpc requests. Remove http.js. Other small cleanups. - What does this PR do? It mostly servers as a cleanup PR after the implementation of the WS RPC in [this PR](#21) - Why are these changes needed? They remove some unnecessary complexity from the code. Fixes LimeChain#529 ## Checklist: - [X] I have read the [contributing guidelines](https://github.com/LimeChain/Fruzhin/blob/dev/CONTRIBUTING.md). - [X] My PR title matches the [Conventional Commits spec](https://www.conventionalcommits.org/). - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [X] All new and existing tests passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fruzhin's web client needs to support all subscription RPC methods via WS. This PR provides such an implementation. Also further adds support for more RPC methods.
Adds support for WS RPC communication with a full node.
So that all required by the polkadot spec RPC methods are supported and a more user friendly RPC api is available.
By adding a WS client implementation that communicates with an external full node. Also exposes a client that can be used to invoke RPC methods.
Fixes LimeChain#519
Checklist: