Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement WsRpcClient and support all required rpc methods. #21

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

Zurcusa
Copy link
Collaborator

@Zurcusa Zurcusa commented Sep 18, 2024

Description

Fruzhin's web client needs to support all subscription RPC methods via WS. This PR provides such an implementation. Also further adds support for more RPC methods.

  • What does this PR do?
    Adds support for WS RPC communication with a full node.
  • Why are these changes needed?
    So that all required by the polkadot spec RPC methods are supported and a more user friendly RPC api is available.
  • How were these changes implemented and what do they affect?
    By adding a WS client implementation that communicates with an external full node. Also exposes a client that can be used to invoke RPC methods.

Fixes LimeChain#519

Checklist:

  • I have read the contributing guidelines.
  • My PR title matches the Conventional Commits spec.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Zurcusa Zurcusa merged commit 03e28d1 into dev Sep 19, 2024
1 check passed
@Zurcusa Zurcusa deleted the 519-support-more-rpc branch September 19, 2024 12:03
Zurcusa added a commit that referenced this pull request Sep 19, 2024
# Description
Remove deprecated http rpc client api export and related code. Remove
LoadBalancer. Use only one node for HTTP rpc requests. Remove http.js.
Other small cleanups.

- What does this PR do?
It mostly servers as a cleanup PR after the implementation of the WS RPC
in [this PR](#21)
- Why are these changes needed?
They remove some unnecessary complexity from the code.

Fixes LimeChain#529

## Checklist:
- [X] I have read the [contributing
guidelines](https://github.com/LimeChain/Fruzhin/blob/dev/CONTRIBUTING.md).
- [X] My PR title matches the [Conventional Commits
spec](https://www.conventionalcommits.org/).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [X] All new and existing tests passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement RPC methods
3 participants