feat: implement protocols #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zurcusa
approved these changes
Sep 9, 2024
| private static String grandpaProtocolChain(String chainId) { | ||
| return chainId.equals("dot") ? "paritytech" : chainId; | ||
| public static String getGrandpaProtocol() { | ||
| return "/paritytech/grandpa/1"; |
There was a problem hiding this comment.
Are we sticking to the legacy protocol string?
There was a problem hiding this comment.
Until we add configuration for the host, yes
src/main/java/com/limechain/network/protocol/grandpa/GrandpaEngine.java
Outdated
Show resolved
Hide resolved
georg-getz
approved these changes
Sep 9, 2024
Grigorov-Georgi
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement grandpa and blockannounce substream/stream protocols
Fixes LimeChain#518
Checklist: