Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: ignore index + macro combination in classification metrics #2443

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Mar 9, 2024

What does this PR do?

Fixes #2441

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2443.org.readthedocs.build/en/2443/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Mar 9, 2024
@SkafteNicki SkafteNicki added this to the v1.3.x milestone Mar 9, 2024
@Borda
Copy link
Member

Borda commented May 21, 2024

@SkafteNicki, what is missing here to make it land? 🐿️

@DimitrisMantas
Copy link

Is this still happening?

@JeroenMandersloot
Copy link

Any chance that this will be worked on in the near future?

@Borda
Copy link
Member

Borda commented Jul 22, 2024

Any chance that this will be worked on in the near future?

cc: @SkafteNicki

@Borda Borda force-pushed the master branch 2 times, most recently from d0a5568 to 9fc79ae Compare September 16, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working topic: Classif
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect result in computing MulticlassRecall macro average when ignore_index is specified
4 participants