Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build images for py3.11 #2138

Merged
merged 8 commits into from
Oct 6, 2023
Merged

build images for py3.11 #2138

merged 8 commits into from
Oct 6, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 4, 2023

What does this PR do?

adding some more images

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2138.org.readthedocs.build/en/2138/

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #2138 (7fd5d2e) into master (1d10277) will increase coverage by 0%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2138   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         293     293           
  Lines       16368   16371    +3     
======================================
+ Hits        14227   14230    +3     
  Misses       2141    2141           

@Borda Borda marked this pull request as draft October 4, 2023 05:58
@Borda Borda marked this pull request as ready for review October 4, 2023 22:58
@Borda Borda enabled auto-merge (squash) October 4, 2023 22:59
@Borda Borda mentioned this pull request Oct 4, 2023
4 tasks
@SkafteNicki SkafteNicki added the test / CI testing or CI label Oct 5, 2023
@SkafteNicki SkafteNicki added this to the v1.3.0 milestone Oct 5, 2023
@mergify mergify bot added the ready label Oct 5, 2023
@Borda
Copy link
Member Author

Borda commented Oct 6, 2023

I fixed some mypy issues but not sure why it was raised/flocked in this "unrelated" change/PR

@Borda Borda enabled auto-merge (squash) October 6, 2023 14:00
@Borda Borda disabled auto-merge October 6, 2023 16:25
@Borda Borda merged commit 89ca22b into master Oct 6, 2023
62 of 69 checks passed
@Borda Borda deleted the docker/py3.11 branch October 6, 2023 16:34
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Oct 14, 2023
Borda added a commit that referenced this pull request Nov 30, 2023
(cherry picked from commit 89ca22b)
Borda added a commit that referenced this pull request Dec 1, 2023
(cherry picked from commit 89ca22b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants