Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added call to setup function of serializer class to set data format #96

Merged
merged 7 commits into from
Apr 11, 2024

Conversation

vgurev
Copy link
Contributor

@vgurev vgurev commented Apr 9, 2024

Fixed bug. No calls were made to the setup function of serializer class. Reading failed for serializers that required setup, for instance, serializers for no_header_numpy fails
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

We wrote a code that writes dataset with numpy arrays. Litdata StreamingDataset fails to read the data. It seems that numpy arrays were serialized as no_header_numpy that requires call to setup function to set data format in serializer class. However, that call is not anywhere in the current code.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@vgurev vgurev requested review from tchaton and awaelchli as code owners April 9, 2024 14:19
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

❗ No coverage uploaded for pull request base (main@c87662a). Click here to learn what that means.
The diff coverage is 100%.

Additional details and impacted files
@@          Coverage Diff          @@
##             main    #96   +/-   ##
=====================================
  Coverage        ?    78%           
=====================================
  Files           ?     29           
  Lines           ?   3408           
  Branches        ?      0           
=====================================
  Hits            ?   2671           
  Misses          ?    737           
  Partials        ?      0           

Copy link
Collaborator

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@tchaton tchaton merged commit 58f7aeb into Lightning-AI:main Apr 11, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants