Added call to setup function of serializer class to set data format #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug. No calls were made to the setup function of serializer class. Reading failed for serializers that required setup, for instance, serializers for no_header_numpy fails
What does this PR do?
We wrote a code that writes dataset with numpy arrays. Litdata StreamingDataset fails to read the data. It seems that numpy arrays were serialized as no_header_numpy that requires call to setup function to set data format in serializer class. However, that call is not anywhere in the current code.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃