Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dist env detection via env vars #95

Merged
merged 7 commits into from
May 13, 2024

Conversation

gkroiz
Copy link
Contributor

@gkroiz gkroiz commented Apr 8, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #91

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@gkroiz gkroiz requested review from tchaton and awaelchli as code owners April 8, 2024 23:16
@gkroiz
Copy link
Contributor Author

gkroiz commented Apr 8, 2024

@tchaton here is the PR based on our conversations in #91. I realized that there are several other objects that used _DistributedEnv, so decided not to go down the route of passing _DistributedEnv as an optional argument. Instead, I went with adding environment variables that can override the detected vars.

Two things regarding this PR's precheck.

  1. I couldn't find a Contributor guideline file, is this signifcantly different than the lightning contributer guideline file?
  2. I didn't find a lot of documentation worth updating, but if you know of any documentation relevant here, I would be happy to update.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@dc29634). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             main    #95   +/-   ##
=====================================
  Coverage        ?    77%           
=====================================
  Files           ?     30           
  Lines           ?   3982           
  Branches        ?      0           
=====================================
  Hits            ?   3050           
  Misses          ?    932           
  Partials        ?      0           

@tchaton tchaton merged commit 58b158a into Lightning-AI:main May 13, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with StreamingDataset when not using all GPUs on host.
2 participants