-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the serialization of scalar valued tensors #431
Fix the serialization of scalar valued tensors #431
Conversation
for more information, see https://pre-commit.ci
By the way, I was concerned for backwards compatibility so I ran a quick check and this fix does not break backwards compatibility. Users with datasets that contain scalar valued tensors and which serialized as pickle can still deserialize correctly. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
===================================
Coverage 78% 78%
===================================
Files 35 35
Lines 5106 5106
===================================
Hits 4006 4006
Misses 1100 1100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it ! Thanks @enrico-stauss
@enrico-stauss Any feedbacks, suggestions about LitData so far ? |
I haven't had very advanced use-cases but from what I can tell LitData works smoothly most of the times and if something comes up, it is a quick fix. Will keep using it for the resource efficiency alone, so you'll probably see me around :) |
Hey @enrico-stauss. That's great. Would you be willing to post on social about LitData ? I am trying to promote it a bit this month. |
I (intentionally) don't really have much of a social media presence, so I don't think I can help you here @tchaton. |
Before submitting
What does this PR do?
Fixes #424.
PR review
Anyone in the community is free to review the PR once the tests have passed.
Did you have fun?
Make sure you had fun coding 🙃