Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: add tiffile serializer #425

Merged
merged 12 commits into from
Nov 28, 2024
Merged

Conversation

robmarkcole
Copy link
Contributor

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@robmarkcole robmarkcole requested a review from tchaton as a code owner November 28, 2024 09:46
Copy link
Collaborator

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test ?

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78%. Comparing base (7ba51ac) to head (8c8dd78).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #425   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        35     35           
  Lines      5094   5106   +12     
===================================
+ Hits       3996   4006   +10     
- Misses     1098   1100    +2     

Copy link
Collaborator

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton merged commit 943c44d into Lightning-AI:main Nov 28, 2024
29 checks passed
@robmarkcole robmarkcole deleted the add-tiffserializer branch November 28, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tif inferred as pickle
2 participants