Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-deterministic CI test failure #390

Merged

Conversation

deependujha
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #389

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@deependujha deependujha requested a review from tchaton as a code owner October 8, 2024 06:07
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78%. Comparing base (6ceea8a) to head (a18e45b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #390   +/-   ##
===================================
- Coverage    78%    78%   -0%     
===================================
  Files        34     34           
  Lines      5031   5037    +6     
===================================
  Hits       3941   3941           
- Misses     1090   1096    +6     

@Borda Borda enabled auto-merge (squash) October 9, 2024 19:24
@Borda Borda merged commit b9aa903 into Lightning-AI:main Oct 9, 2024
28 of 29 checks passed
@deependujha deependujha deleted the fix/race-condition-worker-failed branch October 14, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One of the worker has failed error in test
3 participants