Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove not violated bandit rules from ignore #372

Merged
merged 1 commit into from
Sep 17, 2024
Merged

remove not violated bandit rules from ignore #372

merged 1 commit into from
Sep 17, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 17, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

this prevent to decrease the quality and re-introducing issues

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (25b7cbd) to head (60defc7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #372   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        34     34           
  Lines      5015   5015           
===================================
  Hits       3930   3930           
  Misses     1085   1085           

@Borda Borda requested a review from bhimrazy September 17, 2024 14:13
@tchaton tchaton merged commit 9a3de73 into main Sep 17, 2024
29 checks passed
@tchaton tchaton deleted the ruff/S branch September 17, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants