Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure storage options #365

Merged
merged 2 commits into from
Sep 6, 2024
Merged

azure storage options #365

merged 2 commits into from
Sep 6, 2024

Conversation

mohanreddypmr
Copy link
Contributor

while opting azure blob as input dir , we are not passing azure storage options to azure blob client , I modified those changes.

@deependujha
Copy link
Collaborator

Hey @mohanreddypmr, appreciate your willingness to make litdata better.

However, there's an ongoing PR #348 that aims to fix many similar issues.

Feel free to review it. And, looking forward to more contributions from you.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (92df8af) to head (a5f0ae6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #365   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        34     34           
  Lines      5016   5016           
===================================
  Hits       3929   3929           
  Misses     1087   1087           

@tchaton
Copy link
Collaborator

tchaton commented Sep 6, 2024

Hey @mohanreddypmr, appreciate your willingness to make litdata better.

However, there's an ongoing PR #348 that aims to fix many similar issues.

Feel free to review it. And, looking forward to more contributions from you.

@deependujha Let's land this one to unblock him until your work is merged.

@tchaton tchaton merged commit 7efd761 into Lightning-AI:main Sep 6, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants