Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support downloading from azure blob storage #262

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

jaehwana2z
Copy link
Contributor

@jaehwana2z jaehwana2z commented Jul 23, 2024

Before submitting
  • [ x] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #242

PR review

Support AzureDownloader in downloader.py

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@62c2d8f). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #262   +/-   ##
=====================================
  Coverage        ?    78%           
=====================================
  Files           ?     34           
  Lines           ?   4896           
  Branches        ?      0           
=====================================
  Hits            ?   3802           
  Misses          ?   1094           
  Partials        ?      0           

@tchaton tchaton merged commit a976b0b into Lightning-AI:main Jul 26, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streaming from azure blob storage
3 participants