Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import error in serialization checks #241

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Fix import error in serialization checks #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd45ce4
Fix import error
awaelchli Jul 18, 2024
40c9de9
add test
awaelchli Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/litdata/streaming/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,13 @@ def deserialize(cls, data: bytes) -> Any:
return Image.frombytes(mode, size, raw) # pyright: ignore

def can_serialize(self, item: Any) -> bool:
if not _PIL_AVAILABLE:
return False

from PIL import Image
from PIL.JpegImagePlugin import JpegImageFile

return bool(_PIL_AVAILABLE) and isinstance(item, Image.Image) and not isinstance(item, JpegImageFile)
return isinstance(item, Image.Image) and not isinstance(item, JpegImageFile)


class JPEGSerializer(Serializer):
Expand Down Expand Up @@ -137,9 +140,12 @@ def deserialize(self, data: bytes) -> Union["JpegImageFile", torch.Tensor]:
return img

def can_serialize(self, item: Any) -> bool:
if not _PIL_AVAILABLE:
return False

from PIL.JpegImagePlugin import JpegImageFile

return bool(_PIL_AVAILABLE) and isinstance(item, JpegImageFile)
return isinstance(item, JpegImageFile)


class BytesSerializer(Serializer):
Expand Down
13 changes: 13 additions & 0 deletions tests/streaming/test_serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import random
import sys
from time import time
from unittest import mock

import numpy as np
import pytest
Expand Down Expand Up @@ -100,6 +101,12 @@ def test_pil_serializer(mode):
assert np.array_equal(np_data, np_dec_data)


def test_pil_serializer_available():
serializer = PILSerializer()
with mock.patch("litdata.streaming.serializers._PIL_AVAILABLE", False):
assert not serializer.can_serialize(None)


@pytest.mark.skipif(condition=not _PIL_AVAILABLE, reason="Requires: ['pil']")
def test_jpeg_serializer():
serializer = JPEGSerializer()
Expand All @@ -121,6 +128,12 @@ def test_jpeg_serializer():
assert deserialized_img.shape == torch.Size([3, 28, 28])


def test_jpeg_serializer_available():
serializer = JPEGSerializer()
with mock.patch("litdata.streaming.serializers._PIL_AVAILABLE", False):
assert not serializer.can_serialize(None)


@pytest.mark.flaky(reruns=3)
@pytest.mark.skipif(sys.platform == "win32", reason="Not supported on windows")
def test_tensor_serializer():
Expand Down
Loading