Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in resolver.py #239

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix typo in resolver.py #239

merged 1 commit into from
Jul 17, 2024

Conversation

lud-ds
Copy link
Contributor

@lud-ds lud-ds commented Jul 17, 2024

Error message refers to output_dir.path instead of output_dir.url

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Error message refers to output_dir.path instead of output_dir.url
@lud-ds lud-ds requested review from tchaton and awaelchli as code owners July 17, 2024 14:29
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5d6b8f9). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #239   +/-   ##
=====================================
  Coverage        ?    77%           
=====================================
  Files           ?     33           
  Lines           ?   4696           
  Branches        ?      0           
=====================================
  Hits            ?   3622           
  Misses          ?   1074           
  Partials        ?      0           

@tchaton tchaton merged commit 44b8a40 into Lightning-AI:main Jul 17, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants