-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Updates readme and a few nitpicks #223
Feat: Updates readme and a few nitpicks #223
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
=====================================
Coverage ? 77%
=====================================
Files ? 33
Lines ? 4695
Branches ? 0
=====================================
Hits ? 3621
Misses ? 1074
Partials ? 0 |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
5685611 | Triggered | Generic High Entropy Secret | 84dce3d | tests/streaming/test_resolver.py | View secret |
5685611 | Triggered | Generic High Entropy Secret | 84dce3d | tests/streaming/test_resolver.py | View secret |
5685611 | Triggered | Generic High Entropy Secret | 84dce3d | tests/streaming/test_resolver.py | View secret |
5685611 | Triggered | Generic High Entropy Secret | 84dce3d | tests/streaming/test_resolver.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@@ -819,7 +820,7 @@ def test_dataset_resume_on_future_chunks(tmpdir, monkeypatch): | |||
|
|||
optimize( | |||
fn=_simple_preprocess, | |||
inputs=list(range(8)), | |||
inputs=list(range(5)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this number changed @deependujha?
This example was constructed in a specific way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deependujha Unfortunately, we found another core issue and this seemed to be a legit test failure. @awaelchli is working on it.
Before submitting
What does this PR do?
and, a few nitpicks
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃