Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor optional imports #221

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Refactor optional imports #221

merged 7 commits into from
Jul 12, 2024

Conversation

awaelchli
Copy link
Contributor

Fixes #215

TLDR: Moves optional imports and checks to local imports. This avoids import issues for unrelated features.
See example in #215 why importing optional dependencies at module-level can be problematic.

@awaelchli awaelchli requested a review from tchaton as a code owner July 11, 2024 10:50
@awaelchli awaelchli marked this pull request as draft July 11, 2024 10:50
Copy link

gitguardian bot commented Jul 11, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5685611 Triggered Generic High Entropy Secret 2b0a0ba tests/streaming/test_resolver.py View secret
5685611 Triggered Generic High Entropy Secret 2b0a0ba tests/streaming/test_resolver.py View secret
5685611 Triggered Generic High Entropy Secret 2b0a0ba tests/streaming/test_resolver.py View secret
5685611 Triggered Generic High Entropy Secret 2b0a0ba tests/streaming/test_resolver.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@awaelchli awaelchli marked this pull request as ready for review July 11, 2024 17:29
@awaelchli awaelchli requested a review from deependujha July 11, 2024 17:30
@awaelchli awaelchli added the enhancement New feature or request label Jul 11, 2024
@tchaton tchaton merged commit df8dcd1 into main Jul 12, 2024
32 checks passed
@tchaton tchaton deleted the refactor/optional-imports branch July 12, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid importing optional dependencies at module level
2 participants