Feat: adds support for reading mosaic mds written dataset #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=====================================
Coverage ? 77%
=====================================
Files ? 33
Lines ? 4704
Branches ? 0
=====================================
Hits ? 3625
Misses ? 1079
Partials ? 0 |
deependujha
reviewed
Jul 7, 2024
for more information, see https://pre-commit.ci
deependujha
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Looks good to me.
Added tests for checking if the mds dataset supports Litdata streamingDataset features like train_test_split, subsample, dataloader (last_drop=True | False).
One test fails on mac (timeout), even though I've not changed anything in any function.
|
Thank you @deependujha for adding these additional tests. |
tchaton
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #195.