Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit suggestions #205

Closed
wants to merge 3 commits into from

Conversation

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)
- [github.com/asottile/pyupgrade: v3.15.1 → v3.16.0](asottile/pyupgrade@v3.15.1...v3.16.0)
- [github.com/codespell-project/codespell: v2.2.6 → v2.3.0](codespell-project/codespell@v2.2.6...v2.3.0)
- [github.com/astral-sh/ruff-pre-commit: v0.3.2 → v0.5.0](astral-sh/ruff-pre-commit@v0.3.2...v0.5.0)
@pre-commit-ci pre-commit-ci bot requested review from tchaton and awaelchli as code owners July 2, 2024 00:03
Copy link

gitguardian bot commented Jul 18, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5685611 Triggered Generic High Entropy Secret 4bdc06c tests/streaming/test_resolver.py View secret
5685611 Triggered Generic High Entropy Secret 4bdc06c tests/streaming/test_resolver.py View secret
5685611 Triggered Generic High Entropy Secret 4bdc06c tests/streaming/test_resolver.py View secret
5685611 Triggered Generic High Entropy Secret 4bdc06c tests/streaming/test_resolver.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Borda Borda enabled auto-merge (squash) July 18, 2024 19:30
@tchaton tchaton closed this Jul 19, 2024
auto-merge was automatically disabled July 19, 2024 19:12

Pull request was closed

@tchaton tchaton deleted the pre-commit-ci-update-config branch July 19, 2024 19:12
@Borda
Copy link
Member

Borda commented Jul 19, 2024

@tchaton you do not like fixed code? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants