Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: error while splitting dataset with splits=[0.1, 0.2, 0.7] and support split of 0.0 #187

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

deependujha
Copy link
Collaborator

@deependujha deependujha commented Jun 27, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Under active development. 🚧

Fixes #182 & Fixes #186

Fixes error while splitting dataset with splits=[0.1, 0.2, 0.7] and other small fixes.
Feature: Adds support for split of 0.0

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@deependujha deependujha marked this pull request as draft June 27, 2024 06:19
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@ce79db9). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #187   +/-   ##
=====================================
  Coverage        ?    78%           
=====================================
  Files           ?     33           
  Lines           ?   4327           
  Branches        ?      0           
=====================================
  Hits            ?   3366           
  Misses          ?    961           
  Partials        ?      0           

@tchaton tchaton marked this pull request as ready for review June 27, 2024 06:53
@tchaton tchaton requested a review from Borda as a code owner June 27, 2024 06:53
Copy link
Collaborator

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@tchaton tchaton merged commit a8f33df into Lightning-AI:main Jun 27, 2024
28 checks passed
@deependujha deependujha deleted the fix/failing-train-test-split branch June 27, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

train_test_split fails when asked for splits=[0.1, 0.2, 0.7] train_test_split doesn't support split of 0.0
2 participants