Skip to content

Commit

Permalink
fix:consistent bucket name over the tests
Browse files Browse the repository at this point in the history
  • Loading branch information
bhimrazy committed Oct 14, 2024
1 parent a1b4eff commit 9bf83af
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/streaming/test_downloader.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ def test_s3_downloader_with_s5cmd_no_storage_options(popen_mock, system_mock, tm
popen_mock.return_value = process_mock

# Initialize the S3Downloader without storage options
downloader = S3Downloader("s3://test_bucket", str(tmpdir), [])
downloader = S3Downloader("s3://random_bucket", str(tmpdir), [])

# Action: Call the download_file method
remote_filepath = "s3://test_bucket/sample_file.txt"
remote_filepath = "s3://random_bucket/sample_file.txt"
local_filepath = os.path.join(tmpdir, "sample_file.txt")
downloader.download_file(remote_filepath, local_filepath)

Expand All @@ -56,10 +56,10 @@ def test_s3_downloader_with_s5cmd_with_storage_options(popen_mock, system_mock,
storage_options = {"AWS_ACCESS_KEY_ID": "dummy_key", "AWS_SECRET_ACCESS_KEY": "dummy_secret"}

# Initialize the S3Downloader with storage options
downloader = S3Downloader("s3://test_bucket", str(tmpdir), [], storage_options)
downloader = S3Downloader("s3://random_bucket", str(tmpdir), [], storage_options)

# Action: Call the download_file method
remote_filepath = "s3://test_bucket/sample_file.txt"
remote_filepath = "s3://random_bucket/sample_file.txt"
local_filepath = os.path.join(tmpdir, "sample_file.txt")
downloader.download_file(remote_filepath, local_filepath)

Expand Down

0 comments on commit 9bf83af

Please sign in to comment.