fix distributed tests with pt main #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantiga
approved these changes
Nov 19, 2024
Comment on lines
+133
to
+136
| if "destroy_process_group" in inspect.signature(self.run_test).parameters: | ||
| run_test_kwargs = {"destroy_process_group": False} | ||
| else: | ||
| run_test_kwargs = {} |
There was a problem hiding this comment.
Can you explain how does this work?
I see failures of the TP tests with this PR. Another way to resolve the problem would be to redefine destroy_pg_upon_exit to return False instead of True.
https://github.com/pytorch/pytorch/blob/c418a9ac7501184d4a8cb4443f49e727d43f6be0/torch/testing/_internal/common_distributed.py#L580-L587
There was a problem hiding this comment.
Yeah, well, last week the way things worked were different.
IvanYashchuk
added a commit
that referenced
this pull request
Nov 26, 2024
This reverts commit 8d1637f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch modified the test class to destroy the process group by default, but we want to do this ourselves.