support dynamic getitem in dictionary for symbolic values #1450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old logic assumes getitem in dict is always a constant.
With a script like this:
Running into exceptions here:
Since we now have
PseudoInst.CONSTANT([IntegerProxy name=i0, value=2, static=CONSTRAINT.CONSTRAINABLE])
, which tries to unwrap an IntegerProxy as constant.The updated logic would preserve the wrapped value if it's holding a number proxy. So the above trace becomes something like this: