Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove pointless Controller inheritance from stubs #20

Conversation

juantejer4
Copy link

⚡ Remove pointless Controller inheritance from Laravel boilerplate stubs - 86dr2vb5q

💻 What type of change is this?

  • 💎 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Styling
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build / CI

⭐ Description

I've removed Controller class unnecessary inheritance

Before

image

After

image

✅ Checklist

  • This PR can be merged (it is not a draft, work in progress, or blocked on another PR)
  • I have tested this change locally in multiple screen sizes
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@juantejer4 juantejer4 merged commit fa73d46 into 10.x Jan 8, 2024
2 checks passed
@juantejer4 juantejer4 deleted the feature/CU-86dr2vb5q/remove-pointless-controller-inheritance-from-stubs branch January 8, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants