Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase fork prokect #17

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Rebase fork prokect #17

merged 6 commits into from
Jan 2, 2024

Conversation

sojeda
Copy link
Collaborator

@sojeda sojeda commented Jan 2, 2024

⚡ TaskTitle - ###

💻 What type of change is this?

  • 💎 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Styling
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build / CI

⭐ Description

I've added support for authentication to implement Key Result 2 of OKR1. It includes model, table, controller and test.

📷 Screenshots

Before

After

💬 Comments

This pr is blocked by laravel#1234.
Im awaiting backend changes to be merged before I can complete this, etc.
This

✅ Checklist

  • This PR can be merged (it is not a draft, work in progress, or blocked on another PR)
  • I have tested this change locally in multiple screen sizes
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sojeda sojeda merged commit 6f6cfb0 into Light-it-labs:10.x Jan 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants