Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stores standard on auth store #41

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

walt-it
Copy link
Contributor

@walt-it walt-it commented Oct 17, 2024

⚡ {0} - {1}

💻 What type of change is this?

  • [{3}] 💎 Feature
  • [{4}] 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Styling
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build / CI

⭐ Description

For more background, see ticket {1}[in-progress].

📷 Screenshots

Before

After

💬 Comments

This pr is blocked by #1234.
Im awaiting backend changes to be merged before I can complete this, etc.
This

✅ Checklist

Requirements

  • This change includes database migrations
  • This PR requires changes in the .env file
  • This PR requires to rebuild a table or run a cron manually
  • This PR can be merged (it is not a draft, work in progress, or blocked on another PR)

To review

  • I have tested this change locally in multiple screen sizes
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If my task include an endpoint, I add the endpoint to Hopscotch/Postman Project
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the WIP Work in progress or draft label Oct 17, 2024
@walt-it walt-it requested a review from ThunderNaka October 17, 2024 13:28
@github-actions github-actions bot added To Review and removed WIP Work in progress or draft labels Oct 17, 2024
@walt-it walt-it removed the request for review from ThunderNaka October 17, 2024 14:22
@walt-it walt-it force-pushed the use-stores-standard-on-auth-store branch from 5f4547c to 1dbac42 Compare October 17, 2024 18:53
@walt-it walt-it merged commit ec36446 into main Oct 17, 2024
2 checks passed
@walt-it walt-it deleted the use-stores-standard-on-auth-store branch October 17, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants